Add AliExpress #4712
Merged
Add AliExpress #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new icon
|
@adamrusted Matches perfectly apart from the "p". Could you have a look at it?
|
|
@fbernhart should be fixed - again I was trying to tidy up paths in Illustrator... |
|
@adamrusted It's great to tidy up paths - if it doesn't change the general shapes. But sometimes if you clear up too many points, the icon will look different - especially after optimization. Unfortunately I can still see differences - at a different location of the "p" now. 😅
|
Looks like it'll have to be a precision of 4 then 👀😅 |
|
@fbernhart Let's try again 😅 |
|
@adamrusted Looks good now! 👍🏼 I gave it a try myself, simplifying the path with some "Inkscape magic" ✨. I has less points than yours and a precision of 3: Maybe you could quickly review it? It matches the source perfectly on my end. If it as well matches on your end, feel free to push and merge it. 😊 Otherwise we'll keep your version and merge it. |
Co-Authored-By: Florian Bernhart <70264417+fbernhart@users.noreply.github.com>
|
@fbernhart You and your Inkscape Magic! 😂 |
|
Did you review my path? Can it be merged? |
Sorry, yes! I've pushed it to this PR already - so feel free to merge it. |
ericcornelissen
added a commit
that referenced
this pull request
Jan 17, 2021
# New Icons - Acer (#4680) - AliExpress (#4712) - Bank of America (#4722) - Blazor (#4694) - Blueprint (#4729) - CodeceptJS (#3399) - Codemagic (#4711) - Cucumber (#4754) - Deutsche Bahn (#4210) - Devpost (#4771) - Espressif (#4720) - Flipkart (#4734) - Folium (#4688) - FutureLearn (#4773) - Game Jolt (#4742) - Git LFS (#4737) - Google Optimize (#4785) - Graylog (#4675) - Headspace (#4765) - Home Assistant Community Store (#4755) - Hotjar (#4723) - Jellyfin (#4674) - Kali Linux (#4768) - Less (#4693) - Metro (#3183) - Momenteo (#4676) - NBA (#4739) - New Japan Pro-Wrestling (#2791) - OWASP (#4783) - Pioneer DJ (#4709) - PlayStation 5 (#4641) - Postmates (#4781) - Presto (#4623) - QuickBooks (#4782) - Rolls-Royce (#4772) - Rotten Tomatoes (#4770) - Selenium (#4769) - Semantic UI React (#4743) - Southwest Airlines (#2896) - Taobao (#4632) - The Irish Times (#4752) - TP-Link (#4732) - Unacademy (#4689) - VOX (#2205) - WALKMAN (#4670) - Wikidata (#4738) - Yale (#4721) # Updated Icons - Accusoft (#3751) - Citrix (#4748) - Ferrari (#4778) - General Motors (#4741) - Google Chat (#4695, #4736) - Intel (#4751) - Kahoot! (#4731) - Kia (#4730) - Microsoft (#4649) - Visa (#4719) - Webflow (#4715)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Fixes #3296
Alexa rank: 39
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Used PDF suggested by @PeterShaggyNoble, colour is picked from the CSS of the AliExpress homepage.