New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Git LFS #4737
Add Git LFS #4737
Conversation
Thanks for taking this one on, @loganmarchione - looks like it's failing, though, 'cause the icon isn't quite centred. |
Sorry about that, I corrected it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot on, matches my from-source path perfectly. See below for comments though.
icons/gitlfs.svg
Outdated
@@ -0,0 +1 @@ | |||
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Git LFS icon</title><path d="M0 16.82l12.04 6.948v-9.675L24 7.184l-4.632-2.676-11.96 6.907V15.3l-2.776-1.601V9.813l11.965-6.908L11.966.233 0 7.14zm12-2.79l.04 9.738L24 16.858V7.185z"/></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches perfectly! 💯
One thing I'd suggest is if possible, try and remove any internal points that don't add anything to the icon (see below). I'm also going to ping @simple-icons/maintainers, as while the monochrome treatment here is great, I would like another opinion as to whether the colour change should be outlined or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer a gap (0.5px) where the color changes, conform to our contribution guidelines.
Some icons can't be easily converted to a monochromatic version due to colour changes, shadows, or other effects. For such cases the addition of gaps is the recommended approach, with a preferred width of 0.5px. In some situations a different gap may be required, but that will be determined on a per-case basis.
@loganmarchione Just to give you an idea, it should look like this in my opinion:
How to achieve it in Inkscape (if you use that?)
- Draw a Bezier curve (shortcut: B) along the edges of the box.
- Set the fill to none, the stroke to a width of 0.5px. (while the icon itself has a width/heigth of 24px)
- Convert the stroke to a path.
- Create the difference between the gap and the box (Ctrl + -).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamrusted @fbernhart
Ah ok, I didn't think about that. First, here is the shape with that extra corner removed.
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Git LFS icon</title><path d="M0 16.82l12.04 6.948L24 16.858V7.184l-4.632-2.676-11.96 6.907V15.3l-2.776-1.601V9.813l11.965-6.908L11.966.233 0 7.14z"/></svg>
Here is the 2nd one (with the gap). Let me know if it looks ok and I can add a new commit.
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Git LFS icon</title><path d="M11.967.232L0 7.141v9.68l11.79 6.802v-9.674l11.962-6.91-4.385-2.531-11.959 6.906v3.887l-2.775-1.602V9.813l11.965-6.909L11.967.232zM23.75 7.62l-11.46 6.62v9.095l11.46-6.621V7.619z"/></svg>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick turnaround @loganmarchione! 💪🏻
The second one looks great, though it looks like you've taken the gap out for the entirety of that shape, as opposed to just the two inner sides - I believe if you draw the lines out as @fbernhart details above just on those two sides, and extend them out slightly past the shape, it should work fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok sorry I drew the box around all 4 edges. Try this.
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Git LFS icon</title><path d="M11.967.232L0 7.141v9.68l11.79 6.802v-9.674l11.96-6.91-4.383-2.531-11.959 6.906v3.887l-2.775-1.602V9.813l11.965-6.909L11.967.232zM24 7.472l-11.71 6.764v9.387L24 16.857V7.473z"/></svg>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect @loganmarchione! Would you mind pushing that version to this PR and we can merge it!
One sec, will make the linter happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @loganmarchione 📦
# New Icons - Acer (#4680) - AliExpress (#4712) - Bank of America (#4722) - Blazor (#4694) - Blueprint (#4729) - CodeceptJS (#3399) - Codemagic (#4711) - Cucumber (#4754) - Deutsche Bahn (#4210) - Devpost (#4771) - Espressif (#4720) - Flipkart (#4734) - Folium (#4688) - FutureLearn (#4773) - Game Jolt (#4742) - Git LFS (#4737) - Google Optimize (#4785) - Graylog (#4675) - Headspace (#4765) - Home Assistant Community Store (#4755) - Hotjar (#4723) - Jellyfin (#4674) - Kali Linux (#4768) - Less (#4693) - Metro (#3183) - Momenteo (#4676) - NBA (#4739) - New Japan Pro-Wrestling (#2791) - OWASP (#4783) - Pioneer DJ (#4709) - PlayStation 5 (#4641) - Postmates (#4781) - Presto (#4623) - QuickBooks (#4782) - Rolls-Royce (#4772) - Rotten Tomatoes (#4770) - Selenium (#4769) - Semantic UI React (#4743) - Southwest Airlines (#2896) - Taobao (#4632) - The Irish Times (#4752) - TP-Link (#4732) - Unacademy (#4689) - VOX (#2205) - WALKMAN (#4670) - Wikidata (#4738) - Yale (#4721) # Updated Icons - Accusoft (#3751) - Citrix (#4748) - Ferrari (#4778) - General Motors (#4741) - Google Chat (#4695, #4736) - Intel (#4751) - Kahoot! (#4731) - Kia (#4730) - Microsoft (#4649) - Visa (#4719) - Webflow (#4715)
Issue: Fixes #3368
Alexa rank:
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
In the JSON file, I put this after "Git". Wasn't sure how the space between Git and LFS would affect sorting. Let me know if you want it moved.