Add NBA #4739
Merged
Add NBA #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterShaggyNoble
added
the
new icon
|
@PeterShaggyNoble I can see quite some difference between your version (red) and the source (black). As it seems like you can't access https://www.nba.com directly (I can from Germany here), maybe you can at least access the SVG in the header? It's this one: https://cdn.nba.com/logos/leagues/logo-nba.svg
|
|
Thanks, @fbernhart - icon & colour updated based on the SVG you provided. |
|
@PeterShaggyNoble Perfect! 🏀 ⛹🏼♂️ Now it matches 100%. |
ericcornelissen
added a commit
that referenced
this pull request
Jan 17, 2021
# New Icons - Acer (#4680) - AliExpress (#4712) - Bank of America (#4722) - Blazor (#4694) - Blueprint (#4729) - CodeceptJS (#3399) - Codemagic (#4711) - Cucumber (#4754) - Deutsche Bahn (#4210) - Devpost (#4771) - Espressif (#4720) - Flipkart (#4734) - Folium (#4688) - FutureLearn (#4773) - Game Jolt (#4742) - Git LFS (#4737) - Google Optimize (#4785) - Graylog (#4675) - Headspace (#4765) - Home Assistant Community Store (#4755) - Hotjar (#4723) - Jellyfin (#4674) - Kali Linux (#4768) - Less (#4693) - Metro (#3183) - Momenteo (#4676) - NBA (#4739) - New Japan Pro-Wrestling (#2791) - OWASP (#4783) - Pioneer DJ (#4709) - PlayStation 5 (#4641) - Postmates (#4781) - Presto (#4623) - QuickBooks (#4782) - Rolls-Royce (#4772) - Rotten Tomatoes (#4770) - Selenium (#4769) - Semantic UI React (#4743) - Southwest Airlines (#2896) - Taobao (#4632) - The Irish Times (#4752) - TP-Link (#4732) - Unacademy (#4689) - VOX (#2205) - WALKMAN (#4670) - Wikidata (#4738) - Yale (#4721) # Updated Icons - Accusoft (#3751) - Citrix (#4748) - Ferrari (#4778) - General Motors (#4741) - Google Chat (#4695, #4736) - Intel (#4751) - Kahoot! (#4731) - Kia (#4730) - Microsoft (#4649) - Visa (#4719) - Webflow (#4715)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Closes #3795
Alexa rank: 939
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Icon & colour provided by @mondeja in #3795 (nba.com redirects to this site in Ireland).
Possible alternative treatment:
