Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WALKMAN #4670

Merged
merged 1 commit into from Jan 15, 2021
Merged

Conversation

PeterShaggyNoble
Copy link
Member

WALKMAN

Issue: Closes #4117
Alexa rank: n/a (see below)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

As a child of the 80s who loved his Walkmans, I had to take this one for myself! 馃槅

It is still an active brand but the question is: is it active and popular enough to warrant inclusion in our library.

@PeterShaggyNoble PeterShaggyNoble added new icon Issues or pull requests for adding a new icon in discussion There is an ongoing discussion that should be finished before we can continue labels Jan 7, 2021
@adamrusted
Copy link
Member

Looks good to me - I'm happy for it to be added to the library, but will await another @simple-icons/maintainers approval before merging, just to be sure.

Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many memories! 馃毝 馃帶 馃幎
Thanks @PeterShaggyNoble!

@service-paradis service-paradis merged commit 8fc59f0 into simple-icons:develop Jan 15, 2021
@github-actions github-actions bot removed the in discussion There is an ongoing discussion that should be finished before we can continue label Jan 15, 2021
@PeterShaggyNoble PeterShaggyNoble deleted the add/walkman branch January 15, 2021 15:43
ericcornelissen added a commit that referenced this pull request Jan 17, 2021
# New Icons

- Acer (#4680)
- AliExpress (#4712)
- Bank of America (#4722)
- Blazor (#4694)
- Blueprint (#4729)
- CodeceptJS (#3399)
- Codemagic (#4711)
- Cucumber (#4754)
- Deutsche Bahn (#4210)
- Devpost (#4771)
- Espressif (#4720)
- Flipkart (#4734)
- Folium (#4688)
- FutureLearn (#4773)
- Game Jolt (#4742)
- Git LFS (#4737)
- Google Optimize (#4785)
- Graylog (#4675)
- Headspace (#4765)
- Home Assistant Community Store (#4755)
- Hotjar (#4723)
- Jellyfin (#4674)
- Kali Linux (#4768)
- Less (#4693)
- Metro (#3183)
- Momenteo (#4676)
- NBA (#4739)
- New Japan Pro-Wrestling (#2791)
- OWASP (#4783)
- Pioneer DJ (#4709)
- PlayStation 5 (#4641)
- Postmates (#4781)
- Presto (#4623)
- QuickBooks (#4782)
- Rolls-Royce (#4772)
- Rotten Tomatoes (#4770)
- Selenium (#4769)
- Semantic UI React (#4743)
- Southwest Airlines (#2896)
- Taobao (#4632)
- The Irish Times (#4752)
- TP-Link (#4732)
- Unacademy (#4689)
- VOX (#2205)
- WALKMAN (#4670)
- Wikidata (#4738)
- Yale (#4721)

# Updated Icons

- Accusoft (#3751)
- Citrix (#4748)
- Ferrari (#4778)
- General Motors (#4741)
- Google Chat (#4695, #4736)
- Intel (#4751)
- Kahoot! (#4731)
- Kia (#4730)
- Microsoft (#4649)
- Visa (#4719)
- Webflow (#4715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add walkman logo
3 participants