Skip to content
This repository was archived by the owner on Nov 19, 2021. It is now read-only.
This repository was archived by the owner on Nov 19, 2021. It is now read-only.

Incorrect from field for chat started from within a chatroom #82

@dceejay

Description

@dceejay

If I use a 3rd party client (Swift on Mac) to join a room - then click on a participant to start a direct chat with them - then the stanza.from arriving at the chatroom looks like

'test@rooms.blah.im/me@blah.im'

with the name of the room first and the sender second - and the stanza.type is chat.
The handler for the chat type only looks at the first part and so reports (in this case) - test@rooms.blah.im (i.e. the room) as the sender...

Should it maybe also look at the second part and if the second part (after the slash) contains an @ then use that as the sender ?

I don't know enough of the semantics of the two parts to know if this would be a valid thing to do in all cases ? Any thoughts ? Happy to raise a PR if it makes sense.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions