Python API tries to connect to `/api/folders` in offline mode

[alahiff]

When running in offline mode the Python API tries to connect to /api/folders, e.g.

/api/folders?count=1&filters=%5B%22path+%3D%3D+%2Ftests%22%5D

It looks like it's trying to check if a folder already exists or not.

[wk9874]

@alahiff at which point in the code does it try to connect to this?

[alahiff]

It's this code in init in the file simvue/run.py:

        try:
            self._folder = get_folder_from_path(path=folder)
        except ObjectNotFoundError:
            self._folder = Folder.new(
                path=folder, offline=self._user_config.run.mode == "offline"
            )
            self._folder.commit()  # type: ignore

[wk9874]

Thanks - yep, looks like get_folder_from_path should have an if offline, return type statement in there....

In fact, do we even need that check? If you try to create a new folder with the same path as one which exists on the server, I assume itll just sort of ignore you / return the ID of the already existing folder? @kzscisoft is there any real reason for this check or can it just be removed completely?

[alahiff]

Yes, if you try to create a folder that exists you should get a 409 and the id of the existing folder.