Feat/conversation contact #33
Conversation
… in Verification creation method
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
| await _http.Send<ListContactsResponse>(uri, HttpMethod.Get, cancellationToken); | ||
| request.PageToken = response.NextPageToken; | ||
| foreach (var contact in response.Contacts) yield return contact; | ||
| } while (request.PageToken is not null); |
There was a problem hiding this comment.
note to self
| } while (request.PageToken is not null); | |
| } while (!string.IsNullOrEmpty(request.PageToken)); |
| private string _email; | ||
| private string _externalId; | ||
| private string _id; | ||
| private string _language; |
There was a problem hiding this comment.
From specs it is a dedicated schema and a (long) list of predefined values.
Ideally we should provide enums as helper ?
There was a problem hiding this comment.
Yeah, makes sense.
Side comment: did you enjoy working with enums of 20+ values?
There was a problem hiding this comment.
No 😞
But from SDK user point of view and because not related to any ISO definition, we can just assuming providing list of supported values will be helpful
| /// <returns></returns> | ||
| internal string GetPropertiesMask() | ||
| { | ||
| return string.Join(',', _setFields.Select(StringUtils.ToSnakeCase)); |
There was a problem hiding this comment.
Ideally this logic could be dynamic and dependent of OAS description based onto style and explode specs.
This, to avoid hard coded logic here and logic/helper shared across domains
There was a problem hiding this comment.
Okay, why to avoid makes sense but how, you mean add helpers for that?
I had an idea for that but in a other task where i see the pattern
There was a problem hiding this comment.
Java SDK is based onto this: https://github.com/sinch/sinch-sdk-java/blob/feat/voice/core/src/main/com/sinch/sdk/core/http/URLParameterUtils.java
And thanks to generator tool using OAS file description, generated sources contains directives about parameters format to be used (e.g. https://github.com/sinch/sinch-sdk-java/blob/feat/voice/openapi-contracts/src/main/com/sinch/sdk/domains/numbers/adapters/api/v1/ActiveNumberApi.java#L278)
There was a problem hiding this comment.
Ah, okay, I'll refactor in other task
Add support for contacts api endpoints