Improve type definition. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Masa-Shin
force-pushed
the
fix-deep-type
branch
3 times, most recently
from
90fb08d to
71087d6
Compare
|
CI is failing |
Type inferences for some kind of values(functions, records, promises,.etc) are not correct when deep option is enabled. It is because CamelCaseKeys type accepts Record<string, any> and then accepts some object-like types such as functions or promises.
|
@sindresorhus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some kind of values (such as functions, records, or promises) are incorrectly inferred as
{}when deep option is enabled. It is because CamelCaseKeys acceptsRecord<string, any>and so it admits some non-record-like types such as functions while it infer them as{}. For example,() => numberextendsRecord<string, any>andCamelCaseKeys<() => number>is{}.Reproduction Link
This cause some trouble when you use types like FileList since many of its values would be inferred as
{}. I fixed the issue by adding a condition for whetherCamelCaseKeys<T[P]>is too wide or not.