Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing files with same name are overriden in download path #3

Closed
jwheare opened this issue Jul 20, 2016 · 3 comments
Closed

Existing files with same name are overriden in download path #3

jwheare opened this issue Jul 20, 2016 · 3 comments

Comments

@jwheare
Copy link
Contributor

jwheare commented Jul 20, 2016

Chrome adds an incrementing (1) before the file extension in this case, to avoid potentially disastrous data loss.

@sindresorhus
Copy link
Owner

Can you open an issue on Electron instead and add the link to the issue here? This module is just using the Electron APIs and I think it should be fixed there so it's solved for everyone, not just users of this module.

@jwheare
Copy link
Contributor Author

jwheare commented Jul 20, 2016

Done. I'm switching to Save As… in my project to avoid this issue. Perhaps worth changing the default in electron-context-menu too.

@joshuapinter
Copy link
Contributor

See PR #73 that adds an option to overwrite existing file with the same name.

vishnuchd added a commit to vishnuchd/electron-dl that referenced this issue Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants