Add overwrite option
#73
Conversation
…me name in directory
|
Wow, what timing. I was literally looking for this. @sindresorhus Any idea when this might get merged into master, or should I use @WilsonCWong's master branch for now? Thanks guys! |
|
FYI, tested this out in our project and it works great. Initially creates another file with the typical "(1)" suffix and then when the download completes, overwrites the existing file:
|
sindresorhus
changed the title
overwrite option
| @@ -92,7 +99,7 @@ declare const electronDl: { | |||
| */ | |||
| (options?: electronDl.Options): void; | |||
|
|
|||
| /** | |||
| /** | |||
There was a problem hiding this comment.
Don't do unrelated changes.
|
|
||
| @default false | ||
| */ | ||
| readonly allowOverwrite?: boolean; |
There was a problem hiding this comment.
| readonly allowOverwrite?: boolean; | |
| readonly overwrite?: boolean; |
|
|
||
| /** | ||
| Allows downloaded files to overwrite files with the same name in the directory they are saved to. | ||
|
|
There was a problem hiding this comment.
This should also describe what happens by default, that it adds a number to the filename.
|
You need to add it to the readme too. |
|
Ping |
|
I wonder what release version supports this feature |
|
@PetersonLian It doesn't appear to be in the |
|
@joshuapinter Thanks |
I added an option that would allow downloaded files to overwrite files of the same name in the save directory. It is off by default. I had a use case for it where I wanted to have the program update itself from a remote server and I needed to overwrite existing files to do that. I think it would be nice to have the option to enable it.