-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overwrite
option
#73
Conversation
…me name in directory
Wow, what timing. I was literally looking for this. @sindresorhus Any idea when this might get merged into master, or should I use @WilsonCWong's master branch for now? Thanks guys! |
overwrite
option
@@ -92,7 +99,7 @@ declare const electronDl: { | |||
*/ | |||
(options?: electronDl.Options): void; | |||
|
|||
/** | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do unrelated changes.
|
||
@default false | ||
*/ | ||
readonly allowOverwrite?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readonly allowOverwrite?: boolean; | |
readonly overwrite?: boolean; |
|
||
/** | ||
Allows downloaded files to overwrite files with the same name in the directory they are saved to. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also describe what happens by default, that it adds a number to the filename.
You need to add it to the readme too. |
Ping |
I wonder what release version supports this feature |
@PetersonLian It doesn't appear to be in the |
@joshuapinter Thanks |
I added an option that would allow downloaded files to overwrite files of the same name in the save directory. It is off by default. I had a use case for it where I wanted to have the program update itself from a remote server and I needed to overwrite existing files to do that. I think it would be nice to have the option to enable it.