Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape key? #4

Closed
dthree opened this issue Sep 28, 2015 · 2 comments
Closed

Escape key? #4

dthree opened this issue Sep 28, 2015 · 2 comments

Comments

@dthree
Copy link

dthree commented Sep 28, 2015

Perhaps there should be a key handler for an escape key. I mean, control + c works, but I think there should be something more graceful, such as also adding support for q, similar to less and top.

Otherwise, love it!

@sindresorhus
Copy link
Owner

You can now press the Esc button to gracefully exit. I think that is a more common convention than q. I also want to support search in the future, so better not use q. It currently doesn't work correctly on Node 4.0, though. At least on OS X. You have to press Esc 3 times for it to work. Might be related to: nodejs/node#2890 or nodejs/node#2996 It works correctly in Node 0.12.

@silverwind Thoughts?

Any other suggestion welcome! I want to be super good :)

@dthree
Copy link
Author

dthree commented Sep 29, 2015

Thanks! I like escape.

That's funny. I literally ran into this same escape problem 3 days ago in doing vorpal-less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants