Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize globalResponse in case of ignored HTTPError #1543

Merged
merged 1 commit into from Nov 30, 2020

Conversation

ikorolev93
Copy link
Contributor

@ikorolev93 ikorolev93 commented Nov 30, 2020

This should fix #1540

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

@szmarczak
Copy link
Collaborator

szmarczak commented Nov 30, 2020

Can we move

globalResponse = response;
before the if above instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON shortcut does not work when using throwHttpErrors: false
2 participants