Don't freeze signal when freezing Options #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test please? |
|
What shall I test? That the signal is frozen? That it can be aborted? |
svvac
force-pushed
the
dont-freeze-signal
branch
from
6e9e348
to
9412235
Compare
|
Added tests :
|
szmarczak
approved these changes
Aug 4, 2022
|
Re: failure under node 14, would you rather have the freeze test skipped, or the signal object be mocked when |
svvac
force-pushed
the
dont-freeze-signal
branch
from
9412235
to
a133b37
Compare
|
Skip the test like in |
svvac
force-pushed
the
dont-freeze-signal
branch
from
a133b37
to
077d903
Compare
|
@svvac Please avoid force-pushing unless you need to fix merge conflicts. It really makes code review harder. |
szmarczak
reviewed
Aug 4, 2022
Co-authored-by: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
szmarczak
changed the title
|
Thanks! 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Freezing the abort signal object breaks its functionality under Node.
Fixes #2099