Support FormData without known length #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t forms without known length.
octet-stream
changed the title
|
Some tests are failing, but they are not related to the PR. I don't know why is this happening. |
|
Try to rebase from the |
|
Yeh, now it seem to fail because of typescript choosing the last overload for functions. UPD: I think the fix is rather simple, so I'll do it now as the pify documentation suggests |
octet-stream
commented
Sep 2, 2022
| @@ -68,7 +69,7 @@ const createHttpsTestServer = async (options: HttpsServerOptions = {}): Promise< | |||
|
|
|||
| await pify(server.https.listen.bind(server.https))(); | |||
|
|
|||
| server.caKey = caKey; | |||
| server.caKey = caKey as any; | |||
There was a problem hiding this comment.
I wasn't sure what the exact meaning of this code, so I just added as any in case if this assignment was without type casting to Buffer by intention. Or should I convert it to Buffer?
sindresorhus
approved these changes
Sep 2, 2022
szmarczak
reviewed
Sep 2, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR updates fixes support for FormData instances without known length. In detail:
form-data-encoderdependency to version 2.1.0;FormDataEncoderinstance;got.postrequests usingFormDatawithout known length.Fixes #2111
Checklist