Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs and disable method rewriting on 307 and 308 #2145

Merged
merged 6 commits into from Sep 18, 2022
Merged

Improve docs and disable method rewriting on 307 and 308 #2145

merged 6 commits into from Sep 18, 2022

Conversation

stjosh
Copy link
Contributor

@stjosh stjosh commented Sep 14, 2022

Solves #2136:

  • Improve/extend the documentation on method rewriting behavior
  • Disable method rewriting on 307 and 308 redirects, as this is explicitly prohibited by the spec

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.

@stjosh stjosh mentioned this pull request Sep 14, 2022
1 task
documentation/2-options.md Outdated Show resolved Hide resolved
source/core/index.ts Outdated Show resolved Hide resolved
documentation/2-options.md Outdated Show resolved Hide resolved
source/core/index.ts Outdated Show resolved Hide resolved
source/core/options.ts Outdated Show resolved Hide resolved
test/redirects.ts Outdated Show resolved Hide resolved
@szmarczak szmarczak changed the title Improve documentation and disable method rewriting on 307 and 308 Improve docs and disable method rewriting on 307 and 308 Sep 18, 2022
@szmarczak szmarczak merged commit e049e94 into sindresorhus:main Sep 18, 2022
6 checks passed
@szmarczak
Copy link
Collaborator

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants