Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an AWS service example #255

Merged
merged 2 commits into from
Jan 13, 2017
Merged

Add an AWS service example #255

merged 2 commits into from
Jan 13, 2017

Conversation

reconbot
Copy link
Contributor

closes #248

const aws4 = require('aws4');
const config = require('./config');

// reads keys from the environment or `~/.aws/credentials` could be a pojo
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's pojo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plain old javascript object, I'll update it

region: awsConfig.region,
headers: {
accept: 'application/json',
'Content-Type': 'application/json'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be lowercase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sindresorhus sindresorhus merged commit 24573b7 into sindresorhus:master Jan 13, 2017
@sindresorhus
Copy link
Owner

Thank you :)

@reconbot reconbot deleted the aws branch January 13, 2017 04:24
sindresorhus pushed a commit that referenced this pull request Jan 13, 2017
@reconbot
Copy link
Contributor Author

reconbot commented Jan 13, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Support
2 participants