Add any predicate

[SamVerschueren]

Added the any method so you can write.

ow(1, ow.any(ow.string, ow.number));

I added typings for any with up to 8 parameters. The benefit is that the compiler can now also check (in the previous example) that 1 should be of type string or number. So we get compile-time checking as well out of the box when we use 8 or less parameters.

---

Secondly, I refactored the main Ow function. Now the predicate checks are done in the concrete predicate class itself. I believe this will make extending Ow much easier as we could now create an OptionalPredicate class that has it's own test function seperate from the Predicate and AnyPredicate class. Just check the code, hard to explain and I hope it makes sense :p.

[SamVerschueren]

Not sure about the description.

[sindresorhus]

Test that the value matches at least one of the given predicates.

?

[SamVerschueren]

Yes, much better!

[sindresorhus]

I added typings for any with up to 8 parameters.

Oh wow. That reminds me of https://github.com/Microsoft/TypeScript/blob/master/lib/lib.es2015.promise.d.ts#L41-L113

We really need microsoft/TypeScript#5453 …

[sindresorhus]

Did you pick 8 for a reason? Can we make it 10? Still arbitrary, but feels better.

[SamVerschueren]

Hehe, you're right, 10 is better. I just thought 8 was crazy enough.

[sindresorhus]

Secondly, I refactored the main Ow function. Now the predicate checks are done in the concrete predicate class itself. I believe this will make extending Ow much easier as we could now create an OptionalPredicate class that has it's own test function seperate from the Predicate and AnyPredicate class.

Yeah, makes sense.

[kevva]

Might be a stupid question, but why couldn't this be ow(1, [ow.string, ow.number]);? I guess because of TypeScript 👼?

[sindresorhus]

@kevva Readability too. It's not clear whether it means any or all. In the above case it's clear as those are mutually exclusive, but what about:

ow(unicorn, [ow.string.startsWidth('foo'), ow.string.endsWidth('bar')]);

Does it require a string that both starts with foo and ends with bar, or a string that either starts with foo or ends with bar.

[kevva]

Yeah, sounds reasonable. On a similar note, wouldn't accepting an array in any fix the typings issue though?

[sindresorhus]

What typing issue?

[kevva]

The one where we have to use an arbitrary number like 10 for the arguments :).