Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix username color #450

Merged
merged 1 commit into from Jun 12, 2019
Merged

Fix username color #450

merged 1 commit into from Jun 12, 2019

Conversation

LitoMore
Copy link
Sponsor Contributor

@LitoMore LitoMore commented Dec 3, 2018

The white color is not compatible with the Terminal which has a white background. We could use other colors. I think the reset is a good choice.

Copy link
Collaborator

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice solution. I think it will conflict with #472 but we could probably borrow this concept into there (e.g. root color would default to reset, unless set to a color explicitly).

@LitoMore
Copy link
Sponsor Contributor Author

@mafredri No problem, I suggested this change at here #472 (review).

@sindresorhus sindresorhus merged commit 0357041 into sindresorhus:master Jun 12, 2019
@LitoMore LitoMore deleted the fix-color branch June 13, 2019 05:24
kgrz added a commit to kgrz/pure that referenced this pull request Jul 18, 2019
* upstream/master: (25 commits)
  Fix incorrect color name in the readme (sindresorhus#482)
  1.10.3
  Fix username prompt expansion
  1.10.2
  Bump version number in pure state
  Fix bad set of key/value pairs on old versions of ZSH
  1.10.1
  Suppress warning of WARN_CREATE_GLOBAL option (sindresorhus#479)
  1.10.0
  Update the zsh-async version to reflect the code
  Improve code comments
  Avoid performing prompt reset in zle-line-finish hook (sindresorhus#477)
  Add support for configuring colors with zstyle (sindresorhus#472)
  Improve the style of the continuation prompt (PS2) (sindresorhus#323)
  Fix username color (sindresorhus#450)
  Add `prompt_pure_system_report` for reporting issues (sindresorhus#468)
  Add pure10k to the list of ports (sindresorhus#474)
  Create funding.yml
  Add pure-pwsh to the ports section of the readme (sindresorhus#467)
  Skip grep fork, use native zsh matching (sindresorhus#459)
  ...
filipekiss added a commit to filipekiss/pure that referenced this pull request Jul 19, 2019
* upstream/master:
  Fix incorrect color name in the readme (sindresorhus#482)
  1.10.3
  Fix username prompt expansion
  1.10.2
  Bump version number in pure state
  Fix bad set of key/value pairs on old versions of ZSH
  1.10.1
  Suppress warning of WARN_CREATE_GLOBAL option (sindresorhus#479)
  1.10.0
  Update the zsh-async version to reflect the code
  Improve code comments
  Avoid performing prompt reset in zle-line-finish hook (sindresorhus#477)
  Add support for configuring colors with zstyle (sindresorhus#472)
  Improve the style of the continuation prompt (PS2) (sindresorhus#323)
  Fix username color (sindresorhus#450)
  Add `prompt_pure_system_report` for reporting issues (sindresorhus#468)
  Add pure10k to the list of ports (sindresorhus#474)
  Create funding.yml

# Conflicts:
#	package.json
#	pure.zsh
#	readme.md
kutsan pushed a commit to kutsan/pure that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants