Avoid performing prompt reset in zle-line-finish hook #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't perform a prompt reset at this point because it removes the prompt marks inserted by macOS Terminal. This change will no longer allow the prompt to reset (from ❮ to ❯) when the user hits [Enter] in VI-mode. However, this might actually be the right thing to do. Fixes #476.
|
@RexYuan Can you confirm this fixes your problem? |
|
Sorry for the delay. I just reinstalled with npm but it doesn't seem to work still. Should I have tried something else? Edit: oh I just realized the PR hasn't gone through yet. I'm not familiar with the inner workings of zsh themes so I'm not really sure if this will fix the problem. Sorry. |
|
Thanks @mafredri. I tried the |
kgrz
added a commit
to kgrz/pure
that referenced
this pull request
Jul 18, 2019
* upstream/master: (25 commits) Fix incorrect color name in the readme (sindresorhus#482) 1.10.3 Fix username prompt expansion 1.10.2 Bump version number in pure state Fix bad set of key/value pairs on old versions of ZSH 1.10.1 Suppress warning of WARN_CREATE_GLOBAL option (sindresorhus#479) 1.10.0 Update the zsh-async version to reflect the code Improve code comments Avoid performing prompt reset in zle-line-finish hook (sindresorhus#477) Add support for configuring colors with zstyle (sindresorhus#472) Improve the style of the continuation prompt (PS2) (sindresorhus#323) Fix username color (sindresorhus#450) Add `prompt_pure_system_report` for reporting issues (sindresorhus#468) Add pure10k to the list of ports (sindresorhus#474) Create funding.yml Add pure-pwsh to the ports section of the readme (sindresorhus#467) Skip grep fork, use native zsh matching (sindresorhus#459) ...
filipekiss
added a commit
to filipekiss/pure
that referenced
this pull request
Jul 19, 2019
* upstream/master: Fix incorrect color name in the readme (sindresorhus#482) 1.10.3 Fix username prompt expansion 1.10.2 Bump version number in pure state Fix bad set of key/value pairs on old versions of ZSH 1.10.1 Suppress warning of WARN_CREATE_GLOBAL option (sindresorhus#479) 1.10.0 Update the zsh-async version to reflect the code Improve code comments Avoid performing prompt reset in zle-line-finish hook (sindresorhus#477) Add support for configuring colors with zstyle (sindresorhus#472) Improve the style of the continuation prompt (PS2) (sindresorhus#323) Fix username color (sindresorhus#450) Add `prompt_pure_system_report` for reporting issues (sindresorhus#468) Add pure10k to the list of ports (sindresorhus#474) Create funding.yml # Conflicts: # package.json # pure.zsh # readme.md
kutsan
pushed a commit
to kutsan/pure
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't perform a prompt reset at this point because it removes the prompt marks inserted by macOS Terminal.
This change will no longer allow the prompt to reset (from ❮ to ❯) when the user hits [Enter] in VI-mode. However, this might actually be the right thing to do.
Fixes #476.