Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt_pure_system_report for reporting issues #468

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Conversation

mafredri
Copy link
Collaborator

I created this branch a long time ago as a way with helping users report issues. It was a WIP but I've forgotten what I wanted to include or improve.

Output of running prompt_pure_system_report:

  • Zsh: zsh 5.7.1 (x86_64-apple-darwin18.2.0)
  • Operating system: Mac OS X 10.14.3 (18D109)
  • Terminal program: iTerm.app (3.2.8beta1)
  • Git: git version 2.21.0
  • Pure state:
    • username: ''
    • prompt:
    • version: 1.8.0
  • Virtualenv: export VIRTUAL_ENV_DISABLE_PROMPT=12
  • Prompt: typeset -g PROMPT='%(12V.%F{242}%12v%f .)%(?.%F{magenta}.%F{red})${prompt_pure_state[prompt]}%f '
  • Detected frameworks: None

Thoughts @sindresorhus? I was thinking running this command could be put in the GitHub issue template, but, I realize it will not be helpful if the user can't get Pure installed (as we see occasionally).

Would need to automate updating of prompt_pure_state[version]="1.8.0" during version bump before this can be useful (and possibly detect if running from git and/or if the file is modified?)

@sindresorhus
Copy link
Owner

Yes, definitely useful.

@sindresorhus
Copy link
Owner

@mafredri Is this ready to be merged? I think we can just merge it and improve it in follow-up PRs if needed.

@mafredri
Copy link
Collaborator Author

Yeah, let's merge it. We still need to figure out the auto-bumping of prompt_pure_state[version] and update the issue template but those are separate tasks. (We should avoid updating the issue template anyway until this is part of a proper release.)

@mafredri mafredri merged commit 4e81f15 into master Jun 11, 2019
@mafredri mafredri deleted the issue-report branch June 11, 2019 19:47
kgrz added a commit to kgrz/pure that referenced this pull request Jul 18, 2019
* upstream/master: (25 commits)
  Fix incorrect color name in the readme (sindresorhus#482)
  1.10.3
  Fix username prompt expansion
  1.10.2
  Bump version number in pure state
  Fix bad set of key/value pairs on old versions of ZSH
  1.10.1
  Suppress warning of WARN_CREATE_GLOBAL option (sindresorhus#479)
  1.10.0
  Update the zsh-async version to reflect the code
  Improve code comments
  Avoid performing prompt reset in zle-line-finish hook (sindresorhus#477)
  Add support for configuring colors with zstyle (sindresorhus#472)
  Improve the style of the continuation prompt (PS2) (sindresorhus#323)
  Fix username color (sindresorhus#450)
  Add `prompt_pure_system_report` for reporting issues (sindresorhus#468)
  Add pure10k to the list of ports (sindresorhus#474)
  Create funding.yml
  Add pure-pwsh to the ports section of the readme (sindresorhus#467)
  Skip grep fork, use native zsh matching (sindresorhus#459)
  ...
filipekiss added a commit to filipekiss/pure that referenced this pull request Jul 19, 2019
* upstream/master:
  Fix incorrect color name in the readme (sindresorhus#482)
  1.10.3
  Fix username prompt expansion
  1.10.2
  Bump version number in pure state
  Fix bad set of key/value pairs on old versions of ZSH
  1.10.1
  Suppress warning of WARN_CREATE_GLOBAL option (sindresorhus#479)
  1.10.0
  Update the zsh-async version to reflect the code
  Improve code comments
  Avoid performing prompt reset in zle-line-finish hook (sindresorhus#477)
  Add support for configuring colors with zstyle (sindresorhus#472)
  Improve the style of the continuation prompt (PS2) (sindresorhus#323)
  Fix username color (sindresorhus#450)
  Add `prompt_pure_system_report` for reporting issues (sindresorhus#468)
  Add pure10k to the list of ports (sindresorhus#474)
  Create funding.yml

# Conflicts:
#	package.json
#	pure.zsh
#	readme.md
kutsan pushed a commit to kutsan/pure that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants