Add SetRequired and SetOptional types
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2019 22:06
👍 Some other name ideas: It's really too bad that the built-in |
|
You need to add the types to the readme. https://github.com/sindresorhus/type-fest/blob/master/.github/contributing.md |
sindresorhus
requested changes
Aug 15, 2019
added 8 commits
August 24, 2019 08:00
This expresses intent better and couples the sister types make definition file
crhistianramirez
changed the title
Require and Optionalize typesSetRequired and SetOptional types
added 2 commits
August 24, 2019 09:49
|
@sindresorhus thank you for the feedback I went ahead and resolved each line item. I'd appreciate additional feeedback you might have :) Also did you prefer that I squash all the commits to clean it up? Wasn't sure, the readme didn't mention it. |
sindresorhus
force-pushed
the
master
branch
from
479173a
to
1c76afe
Compare
|
Looks good now. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I'm looking at it maybe SomeRequired and SomeOptional would be better names? Couples the two, as it should and expresses intent pretty well.Edit: changed to SetRequired and SetOptional per feedback from sindresorhus