-
Notifications
You must be signed in to change notification settings - Fork 58
Modified Notebooks according to feedback #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the ##Drop Pipeline
in the cell near the end. That's a SQL cell, so #
is not a comment character. That type of comment should be in a markdown cell. You can move the drop database comment from the next cell in the same way.
Also, there is a space after the else
in the last cell that should be removed.
Done |
I have resolved conficts but pre commit check is failing |
Can you just pull the changes into your clone and push them again? That will run the pre-commit checks. It looks like there's a formatting issue in the notebook file. I think that should fix it and be the end. |
You'll probably have to run the pre-commits manually since you won't have any changes to commit until the run:
|
No description provided.