Skip to content

Conversation

chetanthote
Copy link
Contributor

No description provided.

Copy link
Collaborator

@kesmit13 kesmit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the ##Drop Pipeline in the cell near the end. That's a SQL cell, so # is not a comment character. That type of comment should be in a markdown cell. You can move the drop database comment from the next cell in the same way.

Also, there is a space after the else in the last cell that should be removed.

@chetanthote
Copy link
Contributor Author

Done

@chetanthote
Copy link
Contributor Author

I have resolved conficts but pre commit check is failing

@kesmit13
Copy link
Collaborator

I have resolved conficts but pre commit check is failing

Can you just pull the changes into your clone and push them again? That will run the pre-commit checks. It looks like there's a formatting issue in the notebook file. I think that should fix it and be the end.

@kesmit13
Copy link
Collaborator

I have resolved conficts but pre commit check is failing

Can you just pull the changes into your clone and push them again? That will run the pre-commit checks. It looks like there's a formatting issue in the notebook file. I think that should fix it and be the end.

You'll probably have to run the pre-commits manually since you won't have any changes to commit until the run:

pre-commit run --all-files

@kesmit13 kesmit13 merged commit 6a39ef5 into singlestore-labs:master Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants