-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code for the Promise fake throws on IE11 #2316
Labels
Comments
I agree. The tests are already checking for promise support and the code should do that as well. @muodov Would you care to provide a patch? |
@mantoni sure. It's quite a busy time in my life, so give me a couple of weeks, Ill try to get to it. |
muodov
added a commit
to muodov/sinon
that referenced
this issue
Dec 5, 2020
2 tasks
@mantoni I've created a tiny PR with a fix. Would you mind to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
After the recent change, IE11 throws an exception (Promise is not defined) in this line
To Reproduce
Steps to reproduce the behavior:
Expected behavior
it should gracefully ignore that code piece if Promise is not defined in
self
.Context (please complete the following information):
Additional context
I know. IE11 is not exactly a modern browser, but some companies like ours have to support them for their clients. And it sounds like the fix in sinon will be tiny
The text was updated successfully, but these errors were encountered: