-
Notifications
You must be signed in to change notification settings - Fork 87
Fix: Docker build failure (ModuleNotFoundError) and cypress tests #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to copy whole code before pip3 install -r requirements.txt
? Im not sure why its currently done this way, copying files one by one, running pip3 and only at the end copying whole code.
It's probably done this way so that if someone changes the code, the requirements don't get reinstalled during the Docker build (they would be cached). Copying everything at once would remove that possibility. However, it might actually be better to copy all the files at once - during development, you usually don't rebuild the Docker image that often anyway, and rarely does anyone need a rebuild without updating the Python or Node.js requirements. |
…f `gevent==25.5.1`.
Since the Cypress tests were still failing (https://github.com/Iteron-dev/oioioi/actions/runs/18063771807), I removed the installation of the new Now it seems like everything is working as it should :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds successfully locally. Adding the newline in cypress-apply-settings makes it more robust. LGTM
For some strange reason, the docker build action along with the cypress tests action stopped working on Jun 18. A fix was made 50657ed - but it didn't help with Cypress, only with the docker build action. Unfortunately, as it turns out, the docker build action (including Cypress) still doesn't work due to another error:
This error probably didn't exist before, but now it does because of the installation of a newer version of
setuptools
through dependencies.Long-term, it would be advisable to stop using
setup.py
in place ofpyproject.toml
and gently modernize the build process.