Skip to content

Fix running inwer when inwer doesn't print any output #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2023
Merged

Fix running inwer when inwer doesn't print any output #110

merged 3 commits into from
Sep 2, 2023

Conversation

MasloMaslane
Copy link
Member

Closes #108

@MasloMaslane MasloMaslane requested a review from tonowak September 2, 2023 10:21
@MasloMaslane MasloMaslane self-assigned this Sep 2, 2023
@MasloMaslane MasloMaslane linked an issue Sep 2, 2023 that may be closed by this pull request
Code fails when inwer doesn't print any output #108
Closed
tonowak
tonowak approved these changes Sep 2, 2023
View reviewed changes
Copy link
Collaborator

@tonowak tonowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas how we can stop ourselves from stumbling into a similar bug in the future, or how to find similar bugs in the existing codebase?

@MasloMaslane
Copy link
Member Author

Probably using sinol-make on past tasks will be good for finding more bugs. For future I guess writing more and better tasks would help

@MasloMaslane MasloMaslane merged commit cd4dbce into main Sep 2, 2023
@MasloMaslane MasloMaslane deleted the 108-code-fails-when-inwer-doesnt-print-any-output branch September 2, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonowak tonowak tonowak approved these changes

Assignees

@MasloMaslane MasloMaslane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code fails when inwer doesn't print any output
2 participants
@MasloMaslane @tonowak