Real time output #28
Merged
Real time output #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-chmiel
force-pushed
the
real-time-output
branch
from
b7b0fd4 to
3bbe7de
Compare
Wolf480pl
requested changes
Dec 1, 2021
src/seccomp/policy/DefaultPolicy.cc
Outdated
| "openat"}); | ||
| "openat", | ||
| "newfstatat", | ||
| "pread64"}); |
There was a problem hiding this comment.
pread64 should go in addInputOutputRules()
newfstatat should be in addFileSystemAccessRules()
| verifyTimeUsage(); | ||
| // TODO Save time usage to OutputBuilder. | ||
| auto time = getTimeUsage(); | ||
| outputBuilder_->setRealTimeMicroseconds(time->realTimeUs); |
There was a problem hiding this comment.
I think we should double-check this, but IIRC the old "real-cpu" supervisor uses user time, not real time.
|
|
||
| std::stringstream ss; | ||
| ss << killReasonName(reason) << " " << exitStatus_ << " " | ||
| << milliSecondsElapsed_ << " " << realMilliSecondsElapsed_ << " " |
There was a problem hiding this comment.
I see you've added a new field here, but maybe putting realMilliSecondsElapsed in place of either miliSecondsElapsed or that 0ULL below, it'd be easier to adapt sioworkers and oiejq to parse this?
There was a problem hiding this comment.
You are right, I will replace milliSecondsElapsed
Wolf480pl
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new format oireal
STATUS CODE TIME REAL_TIME NVM MEM SYSC