Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #102

Merged
merged 9 commits into from
Apr 7, 2024
Merged

Bugfix #102

merged 9 commits into from
Apr 7, 2024

Conversation

sirAndros
Copy link
Owner

@sirAndros
feat(dev): add ability to build and dubug on modern VS.
acf3240
@sirAndros
feat(dev): separate dummy provider from debug configuration
def185b
@sirAndros
fix(win): use visible window available on current desktop as parent
a842cf3 
closes #97
probably, could help with #25, #48, #54, #86
@sirAndros
fix: skip checks for WinHello on a priori not supported OS
fb1b2c6 
closes #100
@sirAndros
fix: use main desktop instead of secure one in the thread for dismiss…
cb6bceb 
…ing warnings when try to use winhello on secure desktop (which can't be supported)

closes #92
@sirAndros
fix: get correct OS version in case of wrong KeePass manifest
247d583
@sirAndros
fix: use window handle from the context to bring it to the front
4ad2a16 
#25
@sirAndros
ref: move storing main desktop to KeyManager as it's not what we expe…
457f8f7 
…ct to be changed during the app work
@sirAndros sirAndros mentioned this pull request Apr 2, 2024
Merged
@sirAndros sirAndros requested a review from shuffle-c April 2, 2024 09:49
shuffle-c
shuffle-c reviewed Apr 7, 2024
View reviewed changes
src/Utilities/WinAPI.cs
[DllImport(User32, SetLastError = true)]
public static extern BOOL SetThreadDesktop(HDESK hDesktop);

[DllImport(ntdll, SetLastError = true)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь SetLastError не нужен, но это мелочи

shuffle-c
shuffle-c approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@shuffle-c shuffle-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@shuffle-c shuffle-c merged commit a9133c2 into master Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuffle-c shuffle-c shuffle-c approved these changes

Assignees

@shuffle-c shuffle-c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirAndros @shuffle-c