Two small crash/error fixes for Linux #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading the copyright ID3v2 of a music file, in this piece of code:
wxString::Format("Copyright \x00A9 %s\n", copyright);
The 1st argument is converted to a wxString using the current locale encoding.
If the encoding is UTF-8 (typically Linux), this string is invalidly encoded
and ends up causing a crash inside wxString::format.
Explicitly specify the encoding to avoid this.
According to the wxWidgets wxMenuItem::SetBitmap() documentation (see: https://docs.wxwidgets.org/3.0/classwx_menu_item.html), "SetBitmap() must be called before the item is appended to the menu" On GTK+, not respecting this causes a warning to be printed to the console: (slade:25573): GLib-GObject-WARNING **: 20:16:13.634: invalid cast from 'GtkMenuItem' to 'GtkImageMenuItem' (slade:25573): Gtk-CRITICAL **: 20:16:13.634: gtk_image_menu_item_set_image: assertion 'GTK_IS_IMAGE_MENU_ITEM (image_menu_item)' failed As far as I know this doesn't cause any effect, but fix it to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small crash/error fixes for Linux (for the most part):
A crash when opening a music file with an ID3v2 Copyright tag, due to a format string being invalid UTF-8.
A GTK+ critical warning due to improper usage of
wxMenuItem::SetBitmap().