Create data dir for InstanceChecker if it does not exist #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan200101
commented
May 22, 2023
Comment on lines
+385
to
+386
| if (!wxDirExists(data_dir)) | ||
| wxMkdir(data_dir); |
There was a problem hiding this comment.
the entire branch can also be removed with just a call to wxMkdir, we don't really care if it succeds or not since wxSingleInstanceChecker::Create will inform the user of any problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wxSingleInstanceChecker::Createcannot create a lock in a directory that does not exist, so we check it if doesn't and make it.