Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BUILD_PK3 by default #1664

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

charlesthobe
Copy link
Contributor

@charlesthobe charlesthobe commented Feb 9, 2024

Edit: now it doesn't have a useless flag that needs a PHD

Only touches the PK3 archive if it doesn't match the folder.

@charlesthobe
Copy link
Contributor Author

and for Info-ZIP aka zip it's just -FS or --filesync
it does all of the above.

@charlesthobe
Copy link
Contributor Author

Wait a sec, while zip doesn't touch the archive if there were no changes, 7zip still recreates the archive as slade.pk3.tmp, then deletes the original file and replaces it with the new file 🤦‍♂️

@charlesthobe charlesthobe marked this pull request as draft February 9, 2024 17:20
@charlesthobe charlesthobe force-pushed the pr-build-pk3 branch 2 times, most recently from 48dded6 to 037c290 Compare February 9, 2024 21:38
@charlesthobe
Copy link
Contributor Author

I opted to create a cmake script instead of integrating the changes into the CMakeLists.txt so the command could be run in the build phase instead of the cmake configuration/cache generation, thus it won't be needed to regenerate cmake cache each time a file is changed.

@charlesthobe charlesthobe marked this pull request as ready for review February 9, 2024 21:43
@charlesthobe charlesthobe force-pushed the pr-build-pk3 branch 3 times, most recently from e13c07c to 99006e7 Compare February 9, 2024 22:45
@sirjuddington sirjuddington merged commit 7a65573 into sirjuddington:master Apr 24, 2024
4 checks passed
@charlesthobe charlesthobe deleted the pr-build-pk3 branch May 13, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants