Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback biomes don't work in multiplayer #24

Closed
Mangraz opened this issue Feb 20, 2024 · 12 comments
Closed

Fallback biomes don't work in multiplayer #24

Mangraz opened this issue Feb 20, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@Mangraz
Copy link

Mangraz commented Feb 20, 2024

In multiplayer, the modded biome from Traverse "Autumnal Forest", shows up on the map as a colorful mess. The bug only occurs in multiplayer. Playing the same save file in singleplayer, the map works fine and shows a forest. Using version 1.1.4.
2024-02-20_19 17 26

@sisby-folk
Copy link
Owner

sisby-folk commented Feb 20, 2024

biome tags aren't sent serialized to the client correctly - either traverse is doing something wrong or your loader.

@Mangraz
Copy link
Author

Mangraz commented Feb 22, 2024

I see, I'll report to the Traverse team then. Thanks for your reply!

@sisby-folk sisby-folk changed the title Visual Issues in Multiplayer Traverse biomes don't appear in multiplayer Feb 22, 2024
@sisby-folk
Copy link
Owner

@Mangraz can you check this out on 1.4.2? We've made several improvements to fallbacks and it really should only happen if biome tag sync is completely broken now.

@Mangraz
Copy link
Author

Mangraz commented Mar 11, 2024

Still broken unfortunately. Updated client and server.

@sisby-folk
Copy link
Owner

Can you confirm whether this happens with only traverse, antique atlas, and dependencies? Either way, send a logs/latest.log uploaded to http://mclo.gs/

@Mangraz
Copy link
Author

Mangraz commented Mar 12, 2024

Here's the log. On a sidenote, Nature's Compass seems to be reading biome tags correctly. Shows e. g. Autumnal Forest with a Forest tag etc. Also noticed in the log that Antique Atlas has the same error with BetterNether and BetterEnd, checked ingame and yep, there's the colorful mess again.

Tried clean install of client and server with only Traverse and Antique Atlas, same issue. Client log Server log. Hope this helps!

@sisby-folk
Copy link
Owner

sisby-folk commented Mar 12, 2024

Thanks for that! Definitely seems like biome tags aren't being synchronised - I guess it's possible that vanilla doesn't send biome tags at all? we'll look into it and either ship a workaround if it's a vanilla issue, or report it to traverse if they missed something.

It's also possible that we're running this code too early for tags if they're really sent per-world - that'd be on us - we'll check it out!

@sisby-folk
Copy link
Owner

sisby-folk commented Mar 13, 2024

Replicated - every biome mod has this issue, so it seems like it's either on our end or vanilla's end, we'll take a look today.

@sisby-folk sisby-folk changed the title Traverse biomes don't appear in multiplayer Fallback biomes don't work in multiplayer Mar 13, 2024
@sisby-folk sisby-folk added the bug Something isn't working label Mar 13, 2024
@sisby-folk
Copy link
Owner

good news! looks like its a timing issue on the antique atlas end - we should be able to move our fallback registration later and fix this issue.
image

sisby-folk added a commit that referenced this issue Mar 15, 2024
@sisby-folk
Copy link
Owner

image

fixed in 1.4.3!

@aziles-guts
Copy link

This appears to still be an issue with biomes o' plenty on 1.4.3

@sisby-folk
Copy link
Owner

post a log!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants