Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding blindspot option, v0.9 compat, more default actions #6

Merged
merged 7 commits into from
Oct 22, 2020
Merged

Adding blindspot option, v0.9 compat, more default actions #6

merged 7 commits into from
Oct 22, 2020

Conversation

ancorso
Copy link
Collaborator

@ancorso ancorso commented Oct 21, 2020

This pull request is a hodgepodge of changes including

  • Addition of default pedestrian model
  • Ability to define a vehicle blind spot by direction and angular width
  • Compat with POMDPs v0.9
  • Some changes to default idm values (specifically setting V_des = 15 m/s for vehicles and 1m/s for ped)
  • Changes to the intersection navigation logic to track leading vehicles if they have a small relative t position but are in a different lane

@ancorso ancorso requested a review from mossr October 21, 2020 17:26
@mossr
Copy link
Member

mossr commented Oct 22, 2020

This looks good to me—nothing should impact our use of the framework. Thanks for getting it up to speed with POMDPs v0.9!

mossr
mossr approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@mossr mossr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@ancorso ancorso merged commit fc6779a into master Oct 22, 2020
This was referenced Oct 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossr mossr mossr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ancorso @mossr