Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKALE-4996 Add reentrancy guard for postIncomingMessages #1054

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

yavrsky
Copy link
Contributor

@yavrsky yavrsky commented Mar 9, 2022

  1. Add reentrancy guard for postIncomingMessages
  2. Move incrementing incomingMessageCounter before loop.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1054 (3fd0fd8) into develop (18435c7) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1054      +/-   ##
===========================================
- Coverage    85.66%   85.62%   -0.04%     
===========================================
  Files           24       24              
  Lines         1074     1078       +4     
  Branches       288      289       +1     
===========================================
+ Hits           920      923       +3     
  Misses          64       64              
- Partials        90       91       +1     
Impacted Files Coverage Δ
proxy/contracts/schain/MessageProxyForSchain.sol 68.96% <80.00%> (+0.44%) ⬆️
proxy/contracts/mainnet/MessageProxyForMainnet.sol 76.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18435c7...3fd0fd8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants