Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/code style hash improvements #1905

Merged
merged 11 commits into from
May 27, 2024
Merged

Enhancement/code style hash improvements #1905

merged 11 commits into from
May 27, 2024

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented May 23, 2024 •
edited

Fix some code style and formatting of hashes. See https://github.com/skalenetwork/internal-support/issues/990

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@dimalit dimalit marked this pull request as ready for review May 24, 2024 14:58
olehnikolaiev
olehnikolaiev previously approved these changes May 24, 2024
View reviewed changes
@dimalit dimalit merged commit 93c07eb into stable May 27, 2024
6 of 7 checks passed
@dimalit dimalit deleted the enhancement/code-style-hash-improvements branch May 27, 2024 16:52
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kladkogex kladkogex kladkogex approved these changes

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko DmytroNazarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimalit @kladkogex @olehnikolaiev