Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added decimal place handling based on given currency code #245

Merged
merged 5 commits into from
Mar 8, 2023
Merged

added decimal place handling based on given currency code #245

merged 5 commits into from
Mar 8, 2023

Conversation

julesian
Copy link
Contributor

  • fix non-decimal currency string format not being handled

nighthawk
nighthawk approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@nighthawk nighthawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nighthawk nighthawk merged commit 76213b3 into pre-refactor/swiftify Mar 8, 2023
@nighthawk nighthawk deleted the hotfix/18768-locale-decimal-format branch March 8, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nighthawk nighthawk nighthawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julesian @nighthawk