Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little cleanup #16

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Little cleanup #16

merged 3 commits into from
Feb 16, 2023

Conversation

rsese
Copy link
Contributor

@rsese rsese commented Feb 16, 2023

Why:

looked at this as part of https://github.com/github/skills/issues/96 and though there was a script using gh pr, I found the script wasn't actually used. The course works but went ahead and did a tiny bit of cleanup while I was here to maybe make things a little more explicit for new folks...

What's being changed:

  • biggest thing was step 5 where we didn't explicitly say to update/commit your change like we do in all the other steps

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@rsese rsese requested a review from a team February 16, 2023 21:42
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you for cleaning this up 💖

@rsese rsese merged commit edf6f9e into main Feb 16, 2023
@rsese rsese deleted the rsese-little-cleanup branch February 16, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants