Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cli, add method QRCode.Write(), update readme #3

Merged
merged 3 commits into from
Dec 31, 2016

Conversation

shenwei356
Copy link
Contributor

@shenwei356 shenwei356 commented Dec 31, 2016

Hi @skip2 ,

I add a command-line tool qrcode, which will be built into $GOPATH/bin/ when installing this package by go get. The command can generate QR code and immediately display using imagemagick command "display":

qrcode hello word | display

A method Write method is added for type QRCode so we can write to more output stream:

 func (q *QRCode) Write(size int, out io.Writer) error {}

README.md is also reedited mostly in Markdown format and updated for the CLI.

@shenwei356
Copy link
Contributor Author

From the travis-ci log, it should not be the issue of code.

@skip2
Copy link
Owner

skip2 commented Dec 31, 2016

Try removing the "release" build from the .travis.yml. I think that line's just wrong, there's no go tag called "release", similar to here:

travis-ci/travis-ci#3076

@shenwei356
Copy link
Contributor Author

shenwei356 commented Dec 31, 2016

Yes, it passed

@skip2
Copy link
Owner

skip2 commented Dec 31, 2016

This looks good, thanks! :)

@skip2 skip2 merged commit cf02323 into skip2:master Dec 31, 2016
@enzoh enzoh mentioned this pull request Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants