Problem with finding some headers

[mmdm95]

Inside Request class and inside construct method you have following code that behave wrong (at least for me!)

$this->headers[strtolower($key)] = $value;
$this->headers[strtolower(str_replace('_', '-', $key))] = $value;

I replace this with below code to have some headers like X-CSRF-TOKEN that was not recognizable before

if (substr($key, 0, 5) == 'HTTP_') {
    $this->headers[str_replace(' ', '-', strtolower(str_replace('_', ' ', substr($key, 5))))] = $value;
} else {
    $this->headers[strtolower(str_replace('_', '-', $key))] = $value;
}

[skipperbent]

What webserver are you using? I would be greatfull if you could post your debug-info (see documentation), it will help me debug the error and contains vital information about your webserver and it's header format.

[mmdm95]

Hi, thanks for reply.

As I mentioned before, I test X-CSRF-TOKEN header and request class was not able to detect it.

1. I am using apache webserver
2. I did send a request through ajax with post method
3. and add csrf token in X-CSRF-TOKEN header
4. It'll throw TokenMismatchException inside BaseCsrfVerifier class because it could not detect csrf token
5. the token was not under x-csrf-token key inside headers and it was inside http-x-csrf-token key

The code to detect headers was not optimized but I fix it with mentioned code above and it's ok now.

Also because it'll regenerate csrf token each time after detection, if you send some ajax requests, it'll have problem.

As I can see you are going to create new version. If you can fix some issues that I had and some features, it would be great:

1. Add the ability for class hinting for controller and method

SimpleRouter::get('/some-route', [SomeController::class, 'someMethod']);

2. An issue I had, was through submitting a form like:

<form method="post" action="<?= url('somewhere')->getRelativeUrl(); ?>">
   <input type="text" name="test">
   <button type="submit">submit</button>
</form>

It does not work because getRelativeUrl method add an extra slash after route and form will not submit!
If there was some method like getRelativeUrlTrimmed that trim forward slash from end of route, it'll be nice.

3. A fixation for getting value from a method:

// if I use this
$val = input()->post('some_value', null);

// then I must check it through null like
if(null !== $val) {
   echo $val->getValue();
}

// but if I don't want the value and just want the check
if('x' == input()->post('some_value', null)->getValue()) {
   echo $val->getValue();
}

// as you can see `getValue()` method can not be apply to `null`
// if all values be an `InputItem` object, it would be much easier to use

Thanks for your attention

[skipperbent]

Hi again.

Thanks for the feedback and the detailed explanation, I really appreciate it!

From what you are describing it sounds like the browser and/or ajax is adding some additional naming to the header. I will do some testing and try to add support for better header parsing; it seems like webservers and browsers all have their own ways of specifying the headers.

Great ideas! I will fix the url bugs right away and try to add class hinting feature to the upcoming release.
I really like the last suggestion too as it does minimize the clutter, however I'm afraid it will/could break peoples existing setup - so it might have to be added as a feature for a major release. I've added some labels and will look into that feature in the future.

/ Simon

[skipperbent]

I cannot recreate the url('somewhere')->getRelativeUrl(). Seems like it correctly trimmed on both the getAbsoluteUrl and getRelativeUrl methods.

I've tried routes like /contact and /contact/.