Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Pecee/Http/Response.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function redirect($url) {
}

public function refresh() {
$this->redirect(url());
$this->redirect(Request::getInstance()->getUri());
}

/**
Expand Down
29 changes: 19 additions & 10 deletions src/Pecee/SimpleRouter/RouterBase.php
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
<?php
namespace Pecee\SimpleRouter;

use Pecee\ArrayUtil;
use Pecee\Http\Middleware\BaseCsrfVerifier;
use Pecee\Http\Request;
use Pecee\Url;

class RouterBase {

Expand Down Expand Up @@ -42,8 +40,8 @@ protected function processRoutes(array $routes, array $settings = array(), array
// Loop through each route-request

$activeGroup = null;

$routesCount = count($routes);
$mergedSettings = array();

/* @var $route RouterEntry */
for($i = 0; $i < $routesCount; $i++) {
Expand Down Expand Up @@ -123,7 +121,7 @@ public function routeRequest() {

$routeMatch = $route->matchRoute($this->request);

if($routeMatch && !($routeMatch instanceof RouterGroup)) {
if($routeMatch) {

if(count($route->getRequestMethods()) && !in_array($this->request->getMethod(), $route->getRequestMethods())) {
$routeNotAllowed = true;
Expand All @@ -132,9 +130,9 @@ public function routeRequest() {

$routeNotAllowed = false;

$this->loadedRoute = $routeMatch;
$routeMatch->loadMiddleware($this->request);
$routeMatch->renderRoute($this->request);
$this->loadedRoute = $route;
$route->loadMiddleware($this->request);
$route->renderRoute($this->request);
break;
}
}
Expand Down Expand Up @@ -221,6 +219,15 @@ public function setBaseCsrfVerifier(BaseCsrfVerifier $baseCsrfVerifier) {
return $this;
}

protected function getParamsToArray($query) {
$output = array();
if($query[0] === '?') {
$query = substr($query, 1);
}
parse_str($query, $output);
return $output;
}

protected function processUrl($route, $method = null, $parameters = null, $getParams = null) {

$url = '/' . trim($route->getUrl(), '/');
Expand Down Expand Up @@ -254,7 +261,7 @@ protected function processUrl($route, $method = null, $parameters = null, $getPa
$url = rtrim($url, '/') . '/';

if($getParams !== null && count($getParams)) {
$url .= '?'.Url::arrayToParams($getParams);
$url .= '?' . $this->getParamsToArray($getParams);
}

return $url;
Expand Down Expand Up @@ -328,13 +335,15 @@ public function getRoute($controller = null, $parameters = null, $getParams = nu
$url = array($controller);

if(is_array($parameters)) {
ArrayUtil::append($url, $parameters);
foreach($parameters as $key => $value) {
array_push($url,$value);
}
}

$url = '/' . trim(join('/', $url), '/') . '/';

if(is_array($getParams)) {
$url .= '?' . Url::arrayToParams($getParams);
$url .= '?' . $this->getParamsToArray($getParams);
}

return $url;
Expand Down
2 changes: 1 addition & 1 deletion src/Pecee/SimpleRouter/RouterController.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public function matchRoute(Request $request) {
// Set callback
$this->setCallback($this->controller . '@' . $this->method);

return $this;
return true;
}
}
return null;
Expand Down
6 changes: 3 additions & 3 deletions src/Pecee/SimpleRouter/RouterEntry.php
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ protected function parseParameters($route, $url, $parameterRegex = '[a-z0-9]*?')

$max = count($parameterNames);

if(count($max)) {
if($max) {
for($i = 0; $i < $max; $i++) {
$name = $parameterNames[$i];
$parameterValue = (isset($parameterValues[$name['name']]) && !empty($parameterValues[$name['name']])) ? $parameterValues[$name['name']] : null;
Expand Down Expand Up @@ -332,7 +332,7 @@ public function loadMiddleware(Request $request) {
throw new RouterException($middleware . ' must be instance of Middleware');
}

/* @var $class Middleware */
/* @var $class IMiddleware */
$middleware->handle($request);
}
} else {
Expand All @@ -341,7 +341,7 @@ public function loadMiddleware(Request $request) {
throw new RouterException($this->getMiddleware() . ' must be instance of Middleware');
}

/* @var $class Middleware */
/* @var $class IMiddleware */
$middleware->handle($request);
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/Pecee/SimpleRouter/RouterGroup.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public function __construct() {
parent::__construct();
}

protected function matchDomain() {
protected function matchDomain(Request $request) {
if($this->domain !== null) {

if(is_array($this->domain)) {
Expand All @@ -20,7 +20,7 @@ protected function matchDomain() {
for($i = 0; $i < $max; $i++) {
$domain = $this->domain[$i];

$parameters = $this->parseParameters($domain, request()->getHost(), '[^.]*');
$parameters = $this->parseParameters($domain, $request->getHost(), '[^.]*');

if($parameters !== null) {
$this->parameters = $parameters;
Expand All @@ -31,7 +31,7 @@ protected function matchDomain() {
return null;
}

$parameters = $this->parseParameters($this->domain, request()->getHost(), '[^.]*');
$parameters = $this->parseParameters($this->domain, $request->getHost(), '[^.]*');

if ($parameters !== null) {
$this->parameters = $parameters;
Expand Down Expand Up @@ -60,7 +60,7 @@ public function renderRoute(Request $request) {
throw new RouterException('Method not allowed');
}

if($this->matchDomain() === null) {
if($this->matchDomain($request) === null) {
return null;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Pecee/SimpleRouter/RouterResource.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function renderRoute(Request $request) {
protected function call($method, $parameters) {
$this->setCallback($this->controller . '@' . $method);
$this->parameters = $parameters;
return $this;
return true;
}

public function matchRoute(Request $request) {
Expand Down
6 changes: 3 additions & 3 deletions src/Pecee/SimpleRouter/RouterRoute.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ public function matchRoute(Request $request) {
// Match on custom defined regular expression
if($this->regexMatch) {
$parameters = array();
if(preg_match('/('.$this->regexMatch.')/is', request()->getHost() . $url, $parameters)) {
if(preg_match('/('.$this->regexMatch.')/is', $request->getHost() . $url, $parameters)) {
$this->parameters = (!is_array($parameters[0]) ? array($parameters[0]) : $parameters[0]);
return $this;
return true;
}
return null;
}
Expand All @@ -46,7 +46,7 @@ public function matchRoute(Request $request) {
$this->parameters = $parameters;
}

return $this;
return true;
}

return null;
Expand Down
2 changes: 1 addition & 1 deletion src/Pecee/SimpleRouter/SimpleRouter.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class SimpleRouter {
* @throws RouterException
*/
public static function start($defaultNamespace = null) {
$router = RouterBase::GetInstance();
$router = RouterBase::getInstance();
$router->setDefaultNamespace($defaultNamespace);
$router->routeRequest();
}
Expand Down