Add support for sending User-Agent string to prerenderer. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes changes to argument signature of the BackendBase method get_response_for_url()
|
I just fixed broken tests. Actual tests for added functionality will follow. |
pcraciunoiu
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
Any tests for this would be great @zekzekus do you wanna give that a go before I merge?
Just saw this! |
|
It seems I won't able to work on the tests for a while. So it's up to you merge this or not. For your information I did push this to production via my fork and according to our SEO agency it worked like a charm. |
|
Alright! Better for people to benefit than to hold this off. Thanks! |
|
Uploaded the release 0.3.3 to pypi. On a separate note, are you running python 3? I assume no, but in case you do, an upgrade to support it would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes changes to argument signature of the BackendBase method get_response_for_url()
Whole credit goes to @jdotjdot .
I just removed one redundant commit (it already handled on master branch at the moment) and fix the conflict on AUTHORS file.
Now i am open to suggestions to make this PR better. For example i think it is a better idea to pass only user agent to backend not whole django request. Also if you can clarify how to setup development environment (to run tests etc.) it would be great to make a better contribution.