Close entries streams after read on parse #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slonopotamus
approved these changes
May 13, 2024
|
Looks good. CI is green and you even restored the possibility to pass path instead of io as a bonus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes entry streams by utilizing a block version of get_input_stream which takes care of closing the stream and switches
Zip::File.openfromZip::File.open_buffer, because.open_buffercauses issues on windows in some versions of rubyzip, see rubyzip/rubyzip@ef89a62 and rubyzip/rubyzip@cdef4a5 (output stream may seem irrelevant, but open_buffer writes data to output stream in some cases https://www.rubydoc.info/gems/rubyzip/2.3.2/Zip%2FFile.open_buffer).Fixes #141