Skip to content

Conversation

TKlerx
Copy link
Contributor

@TKlerx TKlerx commented Jul 21, 2021

Description

Add possibility to change pruner for optimize_hyperparameters in TFT according to #589

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor): Not a big change :)
  • Added/modified tests: Not necessary, I guess.
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

@jdb78
Copy link
Collaborator

jdb78 commented Aug 5, 2021

Thanks a lot! This is indeed a useful addition. Could you amend the changelog and add your name to it?

jdb78
jdb78 previously approved these changes Aug 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #619 (4df581e) into master (b3da0c1) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   89.87%   89.89%   +0.01%     
==========================================
  Files          24       24              
  Lines        3714     3710       -4     
==========================================
- Hits         3338     3335       -3     
+ Misses        376      375       -1     
Flag Coverage Δ
cpu 89.89% <ø> (+0.01%) ⬆️
pytest 89.89% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sting/models/temporal_fusion_transformer/tuning.py 96.77% <ø> (-0.06%) ⬇️
.../models/temporal_fusion_transformer/sub_modules.py 86.26% <0.00%> (-0.10%) ⬇️
pytorch_forecasting/models/basic_rnn/__init__.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a433f92...4df581e. Read the comment docs.

@TKlerx
Copy link
Contributor Author

TKlerx commented Aug 9, 2021

Hey Jan,

Thanks for integrating this PR.
Changelog amended. I hope the description ok.

Timo

@jdb78 jdb78 merged commit b7dc39d into sktime:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants