PLIN-3287: basic handling for pointers #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jredh
approved these changes
Jan 18, 2022
jredh
previously approved these changes
Jan 21, 2022
njdullea
changed the title
acofer
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link
https://skuidify.atlassian.net/browse/PLIN-3287
High-Level Description
This PR updates picard's serialization of json blobs. Before, if the value was a pointer to a pointer to null, the null would be populated as the literal string value "null". Now, it populates the value with the proper postgresql null.
Additionally, it updates the hydration for field properties that are pointers. This allows warden to serialize and deserialize fields as null, and then differentiate what properties were actually provided in an update request.
Changelog:
picard.go: Handling for serialization of json blobs where the value is a pointer to a pointer to null.query/hydrate.go: Handling hydration of field properties which are pointers.Related PR
https://github.com/skuid/warden/pull/434