Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cudo] Handle missing project errors #3438

Merged
merged 3 commits into from
May 24, 2024

Conversation

JungleCatSW
Copy link
Contributor

When a user attempted to use skypilot without a project being set in the credentials file (cudo.yml) it threw an error.

  1. Now the instructions have been updated to tell users to create a project.
    1. On sky check it checks for a valid project and instructs on how to create one if it isn't found.
  2. All other uses of project throw an error with a useful message if somehow a user still doesn't have a valid project.

Tested (run the relevant ones):

  • [x ] Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @JungleCatSW! LGTM.

@Michaelvll Michaelvll merged commit 1a82286 into skypilot-org:master May 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants