[CLI] Initialize key cloud authentication details in a config file #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasj
changed the title
samkumar
approved these changes
Jan 16, 2022
There was a problem hiding this comment.
Looks good to me. But, it's a bit odd that you prompt for the Azure secrets but not the AWS or GCP secrets. You may want to consider adding an option to specify those as well for inclusion in the config file. (Or, alternatively, just keep this to GCP project id and Azure subscription id...)
|
I added AWS and GCP credentials to the tool now. It will read these from environment variables or local files first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
CLI init script allows for persistent credentials across
skylarkCLI calls