Implement context-aware RunEventLoop #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modehandler will react on context cancellation
|
resolves #1162 |
|
Hi, added context to run method on socketmodehandler. make pr-prep was successful. Could you please merge it in master, to resolve #1162 ? |
|
and, could you please approve workflow run? It's my first PR.. |
|
|
||
| return r.Client.Run() | ||
| } | ||
|
|
||
| func (r *SocketmodeHandler) RunEventLoopContext(ctx context.Context) error { |
There was a problem hiding this comment.
Suggested change
| func (r *SocketmodeHandler) RunEventLoopContext(ctx context.Context) error { | |
| func (r *SocketmodeHandler) RunEventLoopWithContext(ctx context.Context) error { |
There was a problem hiding this comment.
Since naming convention for context-aware methods has not been determined, leave it as it is in this time.
|
Hi @lololozhkin any chance you could respond to the above comment? -Thanks! |
kanata2
approved these changes
Apr 13, 2023
|
Thanks! LGTM 👍 |
kanata2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented RunEventLoopContext method. now socketmodehandler will react on context cancellation
PR preparation
make pr-prepfrom the root of the repository to run formatting, linting and tests.