Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2FA type to slack user #1183

Merged
merged 2 commits into from
Mar 28, 2023
Merged

add 2FA type to slack user #1183

merged 2 commits into from
Mar 28, 2023

Conversation

imilchev
Copy link
Contributor

Added a missing property to Slack user. Since it is optional (as documented here), I made it optional in the struct too

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
chris-rock pushed a commit to mondoohq/cnquery that referenced this pull request Mar 27, 2023
```typescript
cnquery> slack.users.where( has2FA == true ){ has2FA twoFactorType }
slack.users.where.list: [
  0: {
    twoFactorType: "app"
    has2FA: true
  }
]
```

Note that this PR switches the slack library to a fork. That's required
until the PR I submitted for the upstream repo is merged
slack-go/slack#1183

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

users.go Outdated Show resolved Hide resolved
@kanata2 kanata2 merged commit 5923d7d into slack-go:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants