-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for dynamic route parameters in custom routes #1791
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1791 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 18 18
Lines 1523 1523
Branches 441 441
=======================================
Hits 1253 1253
Misses 172 172
Partials 98 98 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@seratch The requested updates have been made and the version number in these docs has been changed to |
It might be confusing but I've moved this to the existing v3.12.3 and renamed it to v3.13.0 after that. So, the next version is till v3.13.0. The reason why I reused the existing one is that it already had 13 issues/PRs in it and I didn't want to move it one by one 😄 Either way, please forget the version number 3.12.3 -- you can make v3.13 release with these changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I'd recommend merging this PR after releasing a new version including the feature addition
@seratch Ahh I completely missed that! Sneaky yet sensible 😏 I'll hold off on merging until the new version is released 👍 |
Summary
This PR adds supporting documentation to the "Adding custom HTTP routes" section for the enhancements made in #1785. The documentation links out to the official Express documentation for more details, and provides a simple example to showcase this feature.
Requirements