Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing user type in TeamJoinEvent #1890

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

be320
Copy link
Contributor

@be320 be320 commented Jul 9, 2023

Summary

I fixed the missing User type that should be added in teamJoin event Handler and it was already a TODO task in your code. I have created an issue for it, and there is the issue link : #1889

Requirements (place an x in each [ ])

@salesforce-cla
Copy link

salesforce-cla bot commented Jul 9, 2023

Thanks for the contribution! Before we can merge this, we need @be320 to sign the Salesforce Inc. Contributor License Agreement.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Jul 9, 2023
@seratch seratch added this to the 3.13.2 milestone Jul 9, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1890 (e3e2eca) into main (6dc7fc9) will not change coverage.
The diff coverage is n/a.

❗ Current head e3e2eca differs from pull request most recent head 0714163. Consider uploading reports for the commit 0714163 to get more accurate results

@@           Coverage Diff           @@
##             main    #1890   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          18       18           
  Lines        1521     1521           
  Branches      436      436           
=======================================
  Hits         1250     1250           
  Misses        175      175           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented cla:signed TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants