-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a new documentation page about usage in TypeScript projects #644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
======================================
Coverage 91.9% 91.9%
======================================
Files 7 7
Lines 482 482
Branches 90 90
======================================
Hits 443 443
Misses 22 22
Partials 17 17 Continue to review full report at Codecov.
|
a81e93a
to
27a05bb
Compare
27a05bb
to
18053d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@aoberoi @RodneyU215 are you sure about that? microsoft/TypeScript#26220 is still unmerged, and here on my machine with tsc 3.1.1, the correct flag is still
|
Ah, okay it seems I should have done a little more homework. Thank you @ronjouch for checking my work. microsoft/TypeScript#26218 was at one point set to milestone TS 3.1 - and so the information here was anticipated to be right, but it looks like the typescript team moved the goal post to TS 3.2. Not a problem, we'll just remove the part about |
@ronjouch My over sight as well; I should have dug deeper. Thanks a lot for the feedback Ronan! |
Summary
This page covers the most common questions we've seen when integrating this package into a TypeScript project.
fixes #612
fixes #615
Requirements (place an
x
in each[ ]
)